[SWT-0005] Range-based confirmations #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/range-based-confirmations-with-pitch
branch
from
0fdb967 to
85b7d80
Compare
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/range-based-confirmations-with-pitch
branch
from
85b7d80 to
e5ec034
Compare
stmontgomery
approved these changes
Oct 23, 2024
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/range-based-confirmations-with-pitch
branch
from
b15460b to
9754230
Compare
|
@swift-ci test |
|
Stuart has approved this PR and will be updating the forum thread shortly. Merging. |
Swift Testing includes [an interface](https://swiftpackageindex.com/swiftlang/swift-testing/main/documentation/testing/confirmation(_:expectedcount:isolation:sourcelocation:_:)) for checking that some asynchronous event occurs a given number of times (typically exactly once or never at all.) This proposal enhances that interface to allow arbitrary ranges of event counts so that a test can be written against code that may not always fire said event the exact same number of times. Read the full proposal [here]().
grynspan
force-pushed
the
jgrynspan/range-based-confirmations-with-pitch
branch
from
9754230 to
5195fae
Compare
|
@swift-ci test |
grynspan
changed the title
|
@swift-ci test |
|
@swift-ci test Windows |
|
@swift-ci test |
grynspan
added a commit
that referenced
this pull request
Oct 26, 2024
Follow-up to #691. Updates DocC links now that `confirmation()` is overloaded, specifies a minimum Swift version needed to use it, and adds content to "Migrating From XCTest" covering the new overload.
2 tasks
grynspan
added a commit
that referenced
this pull request
Oct 28, 2024
Follow-up to #691. Updates DocC links now that `confirmation()` is overloaded, specifies a minimum Swift version needed to use it, and adds content to "Migrating From XCTest" covering the new overload. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Testing includes an interface for checking that some asynchronous event occurs a given number of times (typically exactly once or never at all.) This proposal enhances that interface to allow arbitrary ranges of event counts so that a test can be written against code that may not always fire said event the exact same number of times.
Read the full proposal here.
Resolves rdar://138499457.
Checklist: